Fix: cannot remove shortcuts (merge setups instead of chain setups) #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
create-slidev
@slidev/client
@slidev/parser
create-slidev-theme
@slidev/cli
@slidev/types
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defineShortcutsSetupare supposed to receive the set of shortcuts and return the new set of shortcuts (based on the received one, possibly removing some). So we have a chain of setups.The current code does a union of setups, merging all results, breaking the previous semantics (which is more useful and which is reflected by the documentation).
This patch brings back the new behavior, using the new, clean setup syntax.